From 056b8be534fa321b2bfd453390bb11176f8bab81 Mon Sep 17 00:00:00 2001
From: justin <justin.g.kruger@gmail.com>
Date: Fri, 20 Dec 2024 17:35:02 +0000
Subject: [PATCH] Cleanup

---
 src/Dodge/Item/Display.hs            | 24 ++++++++-------
 src/Dodge/Item/Weapon/ExtraEffect.hs | 45 ----------------------------
 2 files changed, 14 insertions(+), 55 deletions(-)
 delete mode 100644 src/Dodge/Item/Weapon/ExtraEffect.hs

diff --git a/src/Dodge/Item/Display.hs b/src/Dodge/Item/Display.hs
index 06a37df6d..591aaaad8 100644
--- a/src/Dodge/Item/Display.hs
+++ b/src/Dodge/Item/Display.hs
@@ -5,13 +5,13 @@ module Dodge.Item.Display (
     basicItemDisplay,
 ) where
 
-import Dodge.Item.InvSize
-import Dodge.Data.ComposedItem
-import ShortShow
 import Data.Maybe
+import Dodge.Data.ComposedItem
 import Dodge.Data.Creature
+import Dodge.Item.InvSize
 import LensHelp
 import Padding
+import ShortShow
 
 itemDisplay :: Creature -> ComposedItem -> [String]
 itemDisplay cr ci =
@@ -60,8 +60,12 @@ showAttachItem :: AttachType -> Item -> String
 showAttachItem t itm = case t of
     ZOOMSCOPE -> "ZOOMSCOPE"
     BULLETSYNTH -> "BSYNTH"
-    REMOTESCREEN -> "REMOTE SCREEN " ++ maybe mempty show 
-        (itm ^? itUse . uaParams . apLinkedProjectile . _Just)
+    REMOTESCREEN ->
+        "REMOTE SCREEN "
+            ++ maybe
+                mempty
+                show
+                (itm ^? itUse . uaParams . apLinkedProjectile . _Just)
     HOMINGMODULE -> "HOMING MOD"
     AUGMENTEDHUD -> "AUGMENTED HUD"
 
@@ -72,13 +76,13 @@ showEquipItem eit = case eit of
 
 itemNumberDisplay :: Creature -> ComposedItem -> [String]
 itemNumberDisplay cr ci
-    | EQUIP WRIST_ECG <- ci ^. _1 . itType
-          = [displayPulse $ cr ^?! crType . avatarPulse . pulseProgress]
-    | WeaponTargetingSF <- ci ^. _2
-      = [maybe "" (const "!TARG!") (ci ^? _1 . itTargeting . itTgPos . _Just)]
+    | EQUIP WRIST_ECG <- ci ^. _1 . itType =
+        [displayPulse $ cr ^?! crType . avatarPulse . pulseProgress]
+    | isJust $ ci ^? _1 . itTargeting . itTgPos . _Just =
+        ["!TARG!"]
     | Just x <- ci ^? _1 . itConsumables . magLoadStatus . iaLoaded = [shortShow x]
     | UseAttach (APInt i) <- ci ^. _1 . itUse = [show i]
-    | UseScope OpticScope {_opticZoom = x} <- ci ^. _1 . itUse = [shortShow x]
+    | UseScope OpticScope{_opticZoom = x} <- ci ^. _1 . itUse = [shortShow x]
     | otherwise = mempty
 
 displayPulse :: Int -> String
diff --git a/src/Dodge/Item/Weapon/ExtraEffect.hs b/src/Dodge/Item/Weapon/ExtraEffect.hs
deleted file mode 100644
index 3244f59dc..000000000
--- a/src/Dodge/Item/Weapon/ExtraEffect.hs
+++ /dev/null
@@ -1,45 +0,0 @@
---{-# LANGUAGE BangPatterns #-}
-
-{- |
-Extra weapon effects, supplementing explicit use effects.
--}
-module Dodge.Item.Weapon.ExtraEffect (
---    autoSonarEffect,
-    autoEffect,
---    autoRadarEffect,
-) where
-
-import Dodge.Data.World
---import Dodge.RadarSweep
-import Dodge.SoundLogic
-import LensHelp
-import Sound.Data
-
-autoEffect :: (Item -> Creature -> World -> World) -> Int -> SoundID -> Item -> Creature -> World -> World
-autoEffect eff t sid itm cr w
-    | _eparamInt (_eeParams (_uequipEffect $ _itUse itm)) < 1 =
-        eff itm cr w
-            & cWorld . lWorld . creatures . ix (_crID cr) . crInv . ix (_ilInvID $ _itLocation itm)
-                . itUse
-                . uequipEffect
-                . eeParams
-                . eparamInt
-                .~ t
-            & soundStart OnceSound (_crPos cr) sid Nothing
-    | otherwise =
-        w
-            & cWorld . lWorld . creatures . ix (_crID cr) . crInv . ix (_ilInvID $ _itLocation itm)
-                . itUse
-                . uequipEffect
-                . eeParams
-                . eparamInt
-                -~ 1
-
----- | Automatically send out radar pulses that detect walls.
---autoRadarEffect :: Item -> Creature -> World -> World
---autoRadarEffect = autoEffect (const (aRadarPulse ObWall)) 100 click1S
-
--- | Automatically send out sonar pulses that detect creatures.
---autoSonarEffect :: Item -> Creature -> World -> World
---autoSonarEffect = autoEffect (const (aRadarPulse ObCreature)) 50 click1S
-