Cleanup

src/Dodge/Wall/Damage.hs

@@ -25,31 +25,29 @@ import qualified Data.Set as S
 -- maybeDestroyDoor should rather happen during the door mechanism update
 damageWall :: Damage -> Wall -> (S.Set Int2,World) -> (S.Set Int2,World)
 damageWall dt wl (is,w) = case _wlStructure wl of
-    MachinePart mcid -> f $ w' & cWorld . lWorld . machines . ix mcid . mcDamage .:~ dt
+    MachinePart mcid -> (,) is $ w' & cWorld . lWorld . machines . ix mcid . mcDamage .:~ dt
     BlockPart blid ->
         w' & cWorld . lWorld . blocks . ix blid . blHP -~ dmam
-            & maybeDestroyBlock is blid
+            & maybeDestroyBlock blid
+            & _1 <>~ is
     DoorPart drid _ ->
         w' & cWorld . lWorld . doors . ix drid . drHP -~ dmam
-            & maybeDestroyDoor is drid
-    _ -> f w'
+            & maybeDestroyDoor drid
+            & _1 <>~ is
+    _ -> (is, w')
   where
-    f = (,) is
---    x = case dt of
---        Explosive y _ -> y * 100
---        _ -> dt ^. dmAmount
     (dmam,w') = damMatSideEffect dt (_wlMaterial wl) (Right wl) w
 
 -- block destruction is convoluted...
-maybeDestroyBlock :: S.Set Int2 -> Int -> World -> (S.Set Int2,World)
-maybeDestroyBlock is blid w = case w ^? cWorld . lWorld . blocks . ix blid of
-    Just bl | _blHP bl < 1 -> destroyBlock is bl w
-    _ -> (is,w)
+maybeDestroyBlock :: Int -> World -> (S.Set Int2,World)
+maybeDestroyBlock blid w = case w ^? cWorld . lWorld . blocks . ix blid of
+    Just bl | _blHP bl < 1 -> destroyBlock bl w
+    _ -> (mempty,w)
 
-maybeDestroyDoor :: S.Set Int2 -> Int -> World -> (S.Set Int2, World)
-maybeDestroyDoor is drid w = case w ^? cWorld . lWorld . doors . ix drid of
+maybeDestroyDoor :: Int -> World -> (S.Set Int2, World)
+maybeDestroyDoor drid w = case w ^? cWorld . lWorld . doors . ix drid of
     Just dr | _drHP dr < 1 -> destroyDoor dr w
-    _ -> (is,w)
+    _ -> (mempty,w)
 
 destroyDoor :: Door -> World -> (S.Set Int2, World)
 destroyDoor dr w =