From 91bf1bc62aabe2b45f45155156c8e64f32f71165 Mon Sep 17 00:00:00 2001
From: justin <justin.g.kruger@gmail.com>
Date: Thu, 3 Oct 2024 10:15:17 +0100
Subject: [PATCH] Cleanup UseEquip constructor

---
 ghcidOutput                           |  2 +-
 src/Dodge/Creature/Impulse/UseItem.hs |  4 ++--
 src/Dodge/Creature/State.hs           | 15 ++++++---------
 src/Dodge/Data/Item/Use.hs            |  8 ++------
 src/Dodge/Default/Item/Use.hs         |  5 ++---
 src/Dodge/Item/Display.hs             |  2 +-
 6 files changed, 14 insertions(+), 22 deletions(-)

diff --git a/ghcidOutput b/ghcidOutput
index d6c458305..379a2bff0 100644
--- a/ghcidOutput
+++ b/ghcidOutput
@@ -1 +1 @@
-All good (602 modules, at 10:06:36)
+All good (602 modules, at 10:15:11)
diff --git a/src/Dodge/Creature/Impulse/UseItem.hs b/src/Dodge/Creature/Impulse/UseItem.hs
index 1cdc3af0c..27a68d36a 100644
--- a/src/Dodge/Creature/Impulse/UseItem.hs
+++ b/src/Dodge/Creature/Impulse/UseItem.hs
@@ -37,7 +37,7 @@ itemUseEffect cr it w = case it ^. ldtValue . itUse of
     UseHeld{} -> heldEffect it cr w
             & pointerToItem itm . itUse . heldHammer .~ HammerDown
     UseHotkey{} -> doequipmentchange
-    EquipUse{} -> doequipmentchange
+    UseEquip{} -> doequipmentchange
     (UseConsume eff) -> useC eff (_ldtValue it) cr w
     CraftUse{} -> w
     UseAttach{} -> selectUse it cr  w
@@ -105,7 +105,7 @@ useItemLeftClick cr w = fromMaybe w $ do
     case ituse of
         UseHeld{} -> return w
         UseConsume{} -> return $ useItemLeftClick' cr w
-        EquipUse{} -> return $ useItemLeftClick' cr w
+        UseEquip{} -> return $ useItemLeftClick' cr w
         UseHotkey{} -> return $ useItemLeftClick' cr w
         UseAmmoMag{} -> return w
         _ -> Nothing
diff --git a/src/Dodge/Creature/State.hs b/src/Dodge/Creature/State.hs
index 713d8384a..7a9c8a78e 100644
--- a/src/Dodge/Creature/State.hs
+++ b/src/Dodge/Creature/State.hs
@@ -26,7 +26,6 @@ import Dodge.Item.HeldOffset
 import Dodge.LightSource
 import Dodge.Prop.Gib
 import Dodge.SoundLogic
---import Dodge.WorldEvent.Flash
 import Dodge.Zoning.Creature
 import FoldableHelp
 import Geometry
@@ -72,16 +71,14 @@ stateUpdate f =
         ]
 
 checkDeath :: Creature -> World -> World
-checkDeath cr w
+checkDeath cr
     | _crHP cr > 0 =
-        w
-            & cWorld . lWorld . creatures . ix (_crID cr) . crState . csDamage .~ []
+        cWorld . lWorld . creatures . ix (_crID cr) . crState . csDamage .~ []
     | otherwise =
-        w
-            & dropByState cr
-            & removecr
-            & stopSoundFrom (CrWeaponSound (_crID cr) 0)
-            & corpseOrGib cr
+        dropByState cr
+            . removecr
+            . stopSoundFrom (CrWeaponSound (_crID cr) 0)
+            . corpseOrGib cr
   where
     removecr
         | _crID cr == 0 =
diff --git a/src/Dodge/Data/Item/Use.hs b/src/Dodge/Data/Item/Use.hs
index 3787a1de9..fcd34d3ba 100644
--- a/src/Dodge/Data/Item/Use.hs
+++ b/src/Dodge/Data/Item/Use.hs
@@ -50,13 +50,9 @@ data ItemUse
         , _leftConsumption :: LeftConsumption
         }
     | UseConsume { _cUse :: Cuse }
-    | EquipUse
-        { _equipEffect :: EquipEffect
-        , _equipTargeting :: Maybe TargetingType
-        }
+    | UseEquip { _uequipEffect :: EquipEffect }
     | CraftUse
-    | UseAttach
-        {_uaParams :: AttachParams}
+    | UseAttach {_uaParams :: AttachParams}
     | UseAmmoMag
         { _amagLoadStatus :: ReloadStatus
         , _amagParams :: AmmoParams
diff --git a/src/Dodge/Default/Item/Use.hs b/src/Dodge/Default/Item/Use.hs
index 68814b043..fb3fbb854 100644
--- a/src/Dodge/Default/Item/Use.hs
+++ b/src/Dodge/Default/Item/Use.hs
@@ -21,9 +21,8 @@ defaultLeftUse = UseHotkey
     }
 
 defaultEquipUse :: ItemUse
-defaultEquipUse = EquipUse
-    { _equipEffect = defaultEquip
-    , _equipTargeting = Nothing
+defaultEquipUse = UseEquip
+    { _uequipEffect = defaultEquip
     }
 
 defaultHeldUse :: ItemUse
diff --git a/src/Dodge/Item/Display.hs b/src/Dodge/Item/Display.hs
index e03ffe11b..3c4422fd8 100644
--- a/src/Dodge/Item/Display.hs
+++ b/src/Dodge/Item/Display.hs
@@ -112,7 +112,7 @@ itemNumberDisplay :: Creature -> Item -> [String]
 itemNumberDisplay cr itm = case iu of
     UseHeld{} -> []
     UseHotkey{} -> [showAutoRechargeProgress (_leftConsumption iu)]
-    EquipUse{} -> showEquipmentNumber cr itm
+    UseEquip{} -> showEquipmentNumber cr itm
     CraftUse -> []
     UseConsume {} -> []
     UseAttach {} -> []