Refactor physics exam review scoring to count true/false sub-questions individually and improve accuracy of correct answer calculations

generic/views.py

@@ -1283,17 +1283,53 @@ class ExamViews(View, LoginRequiredMixin):
                 # If we have responses, iterate and count fully-correct answers using
                 # the model's get_answer_score() which encapsulates per-app logic.
                 if total_responses:
-                    cnt = 0
-                    for ua in ua_qs:
+                    # Special-case physics: count each true/false sub-question individually.
+                    if self.app_name == "physics":
+                        # Determine number of sub-items per question
                         try:
-                            score = ua.get_answer_score()
+                            n_sub = len(q.get_questions())
                         except Exception:
-                            # If get_answer_score fails for any answer, skip it
-                            continue
-                        if score == per_question_max:
-                            cnt += 1
-                    correct_count = cnt
-                    correct_pct = round(100.0 * correct_count / total_responses, 1) if total_responses else 0.0
+                            n_sub = None
+
+                        total_subitems = 0
+                        correct_subitems = 0
+                        for ua in ua_qs:
+                            try:
+                                score = ua.get_answer_score()
+                            except Exception:
+                                continue
+                            # score is expected to be iterable (tuple/list) for physics
+                            if isinstance(score, (list, tuple)) and score:
+                                # count numeric-typed positive/1 values as correct
+                                for s in score:
+                                    if isinstance(s, (int, float)) and s > 0:
+                                        correct_subitems += 1
+                                total_subitems += len(score)
+                            else:
+                                # fallback: treat scalar score as single subitem
+                                if isinstance(score, (int, float)):
+                                    if score > 0:
+                                        correct_subitems += 1
+                                    total_subitems += 1
+
+                        # Compute percent over all subitems seen
+                        correct_count = correct_subitems
+                        if total_subitems:
+                            correct_pct = round(100.0 * correct_subitems / total_subitems, 1)
+                        else:
+                            correct_pct = 0.0
+                    else:
+                        cnt = 0
+                        for ua in ua_qs:
+                            try:
+                                score = ua.get_answer_score()
+                            except Exception:
+                                # If get_answer_score fails for any answer, skip it
+                                continue
+                            if score == per_question_max:
+                                cnt += 1
+                        correct_count = cnt
+                        correct_pct = round(100.0 * correct_count / total_responses, 1) if total_responses else 0.0
                 else:
                     correct_count = 0
                     correct_pct = 0.0