Enhance bulk delete functionality by adding user confirmation before submission and removing debug information from the response when no items are deleted.
This commit is contained in:
+1
-7
@@ -211,8 +211,6 @@ def bulk_delete_questions(request):
|
||||
|
||||
deleted = 0
|
||||
errors = []
|
||||
# For debugging: capture what was received
|
||||
received_post = {k: request.POST.getlist(k) for k in request.POST.keys()}
|
||||
try:
|
||||
qs = Model.objects.filter(pk__in=list(ids))
|
||||
deleted = qs.count()
|
||||
@@ -221,12 +219,8 @@ def bulk_delete_questions(request):
|
||||
logger.exception("bulk_delete failed for app=%s ids=%s", app, ids)
|
||||
return JsonResponse({"ok": False, "error": str(e)}, status=500)
|
||||
|
||||
# Render a small fragment. Include debug info when nothing was deleted to aid diagnosis.
|
||||
# Render a small fragment summarising deletions
|
||||
context = {"deleted": deleted, "errors": errors}
|
||||
if deleted == 0:
|
||||
context["debug_post"] = received_post
|
||||
context["debug_ids"] = sorted(list(ids))
|
||||
context["debug_app"] = app
|
||||
return render(request, "generic/partials/bulk_delete_result.html", context)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user