Refactor trainees bulk update logic to improve user matching criteria and enhance clarity in code comments

This commit is contained in:
Ross
2025-10-27 14:03:21 +00:00
parent d9602eeae9
commit 4dc07b1860
2 changed files with 59 additions and 44 deletions
+18 -3
View File
@@ -4262,7 +4262,6 @@ def trainees_bulk_update_from_spreadsheet(request):
- Preview: parse the pasted text and show rows with any matched user / supervisor
- Apply: apply grade and supervisor updates for matched users
"""
logger.debug("Trainees bulk update called")
import re
@@ -4309,11 +4308,27 @@ def trainees_bulk_update_from_spreadsheet(request):
matched_user = None
if first and last:
# Prefer an exact first+last match
qs = User.objects.filter(first_name__iexact=first, last_name__iexact=last)
if not qs.exists():
qs = User.objects.filter(last_name__iexact=last)
if qs.exists():
matched_user = qs.first()
else:
# Fallback: only match by last name when the last-name query returns
# a single candidate AND the candidate's first name reasonably
# matches the provided first token. This avoids ambiguous matches
# (e.g. Maria vs Stephanie both 'Bailey'). We accept a match when
# the candidate first name startswith the first 3 chars of the
# provided first token, or contains it as a substring (case-ins).
candidates = User.objects.filter(last_name__iexact=last)
if candidates.count() == 1:
candidate = candidates.first()
cand_first = (candidate.first_name or "").strip()
if cand_first:
# take at most 3 chars for prefix comparison
prefix = first[:3].lower()
cand_first_low = cand_first.lower()
if cand_first_low.startswith(prefix) or first.lower() in cand_first_low:
matched_user = candidate
matched_supervisor = None
if supervisor_part: