few fixes towards functional status

This commit is contained in:
Ross
2020-10-16 21:38:01 +01:00
parent 774a867f59
commit 644bf9ce76
10 changed files with 261 additions and 66 deletions
+60 -45
View File
@@ -12,6 +12,7 @@ from .forms import AnatomyAnswerForm, MarkAnatomyQuestionForm
from .models import (
AnatomyQuestion,
CidUserAnswer,
UserAnswer,
Exam,
Answers,
HalfMarkAnswers,
@@ -40,7 +41,8 @@ def image_as_base64(image_file):
# encoded_string = base64.b64encode(img_f.read())
encoded_string = base64.b64encode(image_file.file.read())
mimetype, enc = mimetypes.guess_type(image_file.path)
return "data:image/{};base64,{}".format(mimetype, encoded_string.decode("utf-8"))
return "data:image/{};base64,{}".format(mimetype,
encoded_string.decode("utf-8"))
from django.template.defaulttags import register
@@ -60,7 +62,8 @@ def user_is_admin(user):
def question_list(request):
questions = AnatomyQuestion.objects.all()
return render(request, "anatomy/question_list.html", {"questions": questions})
return render(request, "anatomy/question_list.html",
{"questions": questions})
@login_required
@@ -72,15 +75,15 @@ def index(request):
@login_required
def question_detail(request, pk):
question = get_object_or_404(AnatomyQuestion, pk=pk)
return render(request, "anatomy/question_detail.html", {"question": question})
return render(request, "anatomy/question_detail.html",
{"question": question})
@login_required
def answer_question(request, pk):
question = get_object_or_404(AnatomyQuestion, pk=pk)
answer = question.user_answers.filter(
user=request.user
).first() # .filter(user=User)
user=request.user).first() # .filter(user=User)
if request.method == "POST":
if answer:
form = AnatomyAnswerForm(request.POST, instance=answer)
@@ -95,9 +98,10 @@ def answer_question(request, pk):
return redirect("question_detail", pk=pk)
else:
form = AnatomyAnswerForm(instance=answer)
return render(
request, "anatomy/answer_question.html", {"form": form, "question": question}
)
return render(request, "anatomy/answer_question.html", {
"form": form,
"question": question
})
@login_required
@@ -122,12 +126,16 @@ def exam_overview(request, pk):
return render(
request,
"anatomy/exam_overview.html",
{"exam": exam, "questions": questions, "question_number": question_number},
{
"exam": exam,
"questions": questions,
"question_number": question_number
},
)
@login_required
def exam(request, pk, sk):
def exam_take(request, pk, sk):
exam = get_object_or_404(Exam, pk=pk)
questions = exam.exam_questions.all()
@@ -146,9 +154,8 @@ def exam(request, pk, sk):
# Get data for flagged
# answered_questions = UserAnswer.objects.filter(user=request.user).values_list("question__pk", flat=True)
user_answer_data = UserAnswer.objects.filter(user=request.user).values_list(
"question__pk", "answer", "flagged"
)
user_answer_data = UserAnswer.objects.filter(
user=request.user).values_list("question__pk", "answer", "flagged")
# flagged_questions = UserAnswer.objects.filter(user=request.user, flagged=True).values_list("question__pk", flat=True)
# flagged_questions I= UserAnswer.filter(user=request.user, ).values_list("question__pk", flat=True)
@@ -162,8 +169,7 @@ def exam(request, pk, sk):
# u = question.user_answers
answer = question.user_answers.filter(
user=request.user
).first() # .filter(user=User)
user=request.user).first() # .filter(user=User)
if request.method == "POST":
if answer:
form = AnatomyAnswerForm(request.POST, instance=answer)
@@ -176,9 +182,9 @@ def exam(request, pk, sk):
# answer.published_date = timezone.now()
answer.save()
if "next" in request.POST:
return redirect("exam", pk=pk, sk=n + 1)
return redirect("anatomy:exam_take", pk=pk, sk=n + 1)
elif "previous" in request.POST:
return redirect("exam", pk=pk, sk=n - 1)
return redirect("anatomy:exam_take", pk=pk, sk=n - 1)
else:
form = AnatomyAnswerForm(instance=answer)
return render(
@@ -214,9 +220,9 @@ def postExamAnswers(request):
for k in request.POST.dict():
for q in json.loads(k):
# As access is not restricted make sure the data appears valid
if (not isinstance(q["cid"], int)) or (
not isinstance(q["eid"], int) or (not isinstance(q["ans"], str))
):
if (not isinstance(q["cid"],
int)) or (not isinstance(q["eid"], int) or
(not isinstance(q["ans"], str))):
return JsonResponse({"success": False})
# The model should catch invalid data but this should be less intensive
@@ -224,12 +230,21 @@ def postExamAnswers(request):
if q["cid"] > max_int or q["eid"] > max_int:
return JsonResponse({"success": False})
exam = get_object_or_404(Exam, pk=q["eid"])
if not exam.active:
return JsonResponse({
"success":
False,
"error":
"No active exam: {}".format(q["eid"])
})
exiting_answers = CidUserAnswer.objects.filter(
question__id=q["qid"], exam__id=q["eid"], cid=q["cid"]
)
question__id=q["qid"], exam__id=q["eid"], cid=q["cid"])
if not exiting_answers:
ans = UserAnswer(answer=q["ans"], cid=q["cid"])
ans = CidUserAnswer(answer=q["ans"], cid=q["cid"])
ans.question_id = q["qid"]
ans.exam_id = q["eid"]
@@ -258,9 +273,10 @@ def mark_overview(request, pk):
questions = exam.exam_questions.all()
return render(
request, "anatomy/mark_overview.html", {"exam": exam, "questions": questions}
)
return render(request, "anatomy/mark_overview.html", {
"exam": exam,
"questions": questions
})
@login_required
@@ -286,12 +302,9 @@ def mark(request, pk, sk):
half_correct_answers = [i.answer for i in question.half_mark_answers.all()]
incorrect_answers = [i.answer for i in question.incorrect_answers.all()]
user_answers = (
set([i.answer for i in question.user_answers.all()])
- set(correct_answers)
- set(half_correct_answers)
- set(incorrect_answers)
) # .filter(user=User)
user_answers = (set([i.answer for i in question.user_answers.all()]) -
set(correct_answers) - set(half_correct_answers) -
set(incorrect_answers)) # .filter(user=User)
user_answers = set([i for i in user_answers if i.strip() != ""])
if request.method == "POST":
@@ -343,9 +356,9 @@ def mark(request, pk, sk):
# answer.published_date = timezone.now()
# answer.save()
if "next" in request.POST:
return redirect("mark", pk=pk, sk=n + 1)
return redirect("anatomy:mark", pk=pk, sk=n + 1)
elif "previous" in request.POST:
return redirect("mark", pk=pk, sk=n - 1)
return redirect("anatomy:mark", pk=pk, sk=n - 1)
else:
form = MarkAnatomyQuestionForm()
return render(
@@ -360,10 +373,15 @@ def mark(request, pk, sk):
},
)
def active_exams(request):
def exam_json(request, pk):
exam = get_object_or_404(Exam, pk=pk)
if not exam.active:
raise Http404("No available exam")
questions = exam.exam_questions.all()
exam_questions = defaultdict(dict)
@@ -392,11 +410,8 @@ def exam_scores_cid(request, pk):
questions = exam.exam_questions.all()
cids = (
UserAnswer.objects.filter(question__in=questions)
.values_list("cid", flat=True)
.distinct()
)
cids = (CidUserAnswer.objects.filter(question__in=questions).values_list(
"cid", flat=True).distinct())
user_answers_and_marks = defaultdict(list)
user_answers_marks = defaultdict(list)
@@ -416,7 +431,8 @@ def exam_scores_cid(request, pk):
ans = s[0].answer
if ans in q.answers.all().values_list("answer", flat=True):
a = 2
elif ans in q.half_mark_answers.all().values_list("answer", flat=True):
elif ans in q.half_mark_answers.all().values_list("answer",
flat=True):
a = 1
else:
a = 0
@@ -467,9 +483,8 @@ def exam_scores(request, pk):
questions = exam.exam_questions.all()
users = (
UserAnswer.objects.filter(question__in=questions).values_list("user").distinct()
)
users = (CidUserAnswer.objects.filter(
question__in=questions).values_list("user").distinct())
user_answers_and_marks = defaultdict(list)
user_answers_marks = defaultdict(list)
@@ -489,7 +504,8 @@ def exam_scores(request, pk):
ans = s[0].answer
if ans in q.answers.all().values_list("answer", flat=True):
a = 2
elif ans in q.half_mark_answers.all().values_list("answer", flat=True):
elif ans in q.half_mark_answers.all().values_list("answer",
flat=True):
a = 1
else:
a = 0
@@ -527,4 +543,3 @@ def exam_scores(request, pk):
"user_answers_and_marks": user_answers_and_marks,
},
)