This commit is contained in:
Ross
2021-10-16 11:41:48 +01:00
parent fe5bfd4e11
commit cb20d21d5c
3 changed files with 76 additions and 46 deletions
+3 -2
View File
@@ -258,8 +258,9 @@ class Rapid(models.Model):
[i for i in user_answer_queryset if i.normal == False and i.answer_compare not in marked_answers] [i for i in user_answer_queryset if i.normal == False and i.answer_compare not in marked_answers]
) )
#unmarked_answers = user_answers - self.get_marked_answers() return [i.answer_compare for i in unmarked_answers]
# Marker code below is not used
if marker is None: if marker is None:
return [i.answer_compare for i in unmarked_answers] return [i.answer_compare for i in unmarked_answers]
+38 -26
View File
@@ -43,32 +43,44 @@
{% endif %} {% endif %}
<div class="marking-list"> <div class="marking-list">
Unmarked: {% if not review %}
<ul id="new-answer-list" class="answer-list rapid"> Unmarked:
{% for answer in user_answers %} <ul id="new-answer-list" class="answer-list rapid">
<li> {% for answer in user_answers %}
<pre><span class="answer not-marked">{{ answer }}</span></pre> <li>
</li> <pre><span class="answer not-marked">{{ answer }}</span></pre>
{% endfor %} </li>
</ul> {% endfor %}
Marked: </ul>
<ul id="marked-answer-list" class="answer-list rapid">
{% for answer in correct_answers %} Marked:
<li> <ul id="marked-answer-list" class="answer-list rapid">
<pre><span class="answer correct" title="{{answer}}">{{ answer }}</span></pre> {% for answer in correct_answers %}
</li> <li>
{% endfor %} <pre><span class="answer correct" title="{{answer}}">{{ answer }}</span></pre>
{% for answer in half_mark_answers %} </li>
<li> {% endfor %}
<pre><span class="answer half-correct" title="{{answer}}">{{ answer }}</span></pre> {% for answer in half_mark_answers %}
</li> <li>
{% endfor %} <pre><span class="answer half-correct" title="{{answer}}">{{ answer }}</span></pre>
{% for answer in incorrect_answers %} </li>
<li> {% endfor %}
<pre><span class="answer incorrect" title="{{answer}}">{{ answer }}</span></pre> {% for answer in incorrect_answers %}
</li> <li>
{% endfor %} <pre><span class="answer incorrect" title="{{answer}}">{{ answer }}</span></pre>
</ul> </li>
{% endfor %}
</ul>
{% else %}
To review:
<ul id="new-answer-list" class="answer-list rapid">
{% for answer, mark in review_user_answers %}
<li>
<pre><span class="answer not-marked" dataset-mark="{{mark}}">{{ answer }}</span></pre>
</li>
{% endfor %}
</ul>
{% endif %}
<div class="answer-list key">Key: <span class="correct">2 Marks</span>, <span class="half-correct">1 <div class="answer-list key">Key: <span class="correct">2 Marks</span>, <span class="half-correct">1
Mark</span>, <span class="incorrect">0 Marks</span></div> Mark</span>, <span class="incorrect">0 Marks</span></div>
</div> </div>
+35 -18
View File
@@ -605,16 +605,6 @@ def mark(request, exam_pk, sk, unmarked_exam_answers_only=True, review=False):
except IndexError: except IndexError:
raise Http404("Exam question does not exist") raise Http404("Exam question does not exist")
answers_dict = {}
for ans in question.answers.all():
answers_dict[ans.answer_compare] = ans
if unmarked_exam_answers_only:
unmarked_user_answers = question.get_unmarked_user_answers(exam_pk=exam_pk)
else:
unmarked_user_answers = question.get_unmarked_user_answers()
if request.method == "POST": if request.method == "POST":
@@ -667,15 +657,16 @@ def mark(request, exam_pk, sk, unmarked_exam_answers_only=True, review=False):
else: else:
form = MarkRapidQuestionForm() form = MarkRapidQuestionForm()
if unmarked_exam_answers_only: #answers_dict = {}
correct_answers = []
half_mark_answers = []
incorrect_answers = []
else:
correct_answers = question.answers.filter(status=Answer.MarkOptions.CORRECT)
half_mark_answers = question.answers.filter(status=Answer.MarkOptions.HALF_MARK)
incorrect_answers = question.answers.filter(status=Answer.MarkOptions.INCORRECT)
#for ans in question.answers.all():
# answers_dict[ans.answer_compare] = ans
correct_answers = []
half_mark_answers = []
incorrect_answers = []
review_user_answers = []
# this could be improved # this could be improved
if question.normal: if question.normal:
incorrect_answers = question.get_user_answers() incorrect_answers = question.get_user_answers()
@@ -683,6 +674,31 @@ def mark(request, exam_pk, sk, unmarked_exam_answers_only=True, review=False):
incorrect_answers.remove("") incorrect_answers.remove("")
if "normal" in incorrect_answers: if "normal" in incorrect_answers:
incorrect_answers.remove("normal") incorrect_answers.remove("normal")
else:
if review:
unmarked_user_answers = question.get_user_answers(exam_pk=exam_pk)
elif unmarked_exam_answers_only:
unmarked_user_answers = question.get_unmarked_user_answers(exam_pk=exam_pk)
else:
unmarked_user_answers = question.get_unmarked_user_answers()
if not unmarked_exam_answers_only or review:
correct_answers = question.answers.filter(status=Answer.MarkOptions.CORRECT)
half_mark_answers = question.answers.filter(status=Answer.MarkOptions.HALF_MARK)
incorrect_answers = question.answers.filter(status=Answer.MarkOptions.INCORRECT)
if review:
for ans in unmarked_user_answers:
mark = "unmarked"
if ans in correct_answers:
mark = "correct"
elif ans in half_mark_answers:
mark = "half-mark"
elif ans in incorrect_answers:
mark = "incorrect"
review_user_answers.append(ans, mark)
return render( return render(
request, request,
@@ -695,6 +711,7 @@ def mark(request, exam_pk, sk, unmarked_exam_answers_only=True, review=False):
"question_number": n, "question_number": n,
"question_details": question_details, "question_details": question_details,
"user_answers": unmarked_user_answers, "user_answers": unmarked_user_answers,
"review_user_answers": review_user_answers,
"correct_answers": correct_answers, "correct_answers": correct_answers,
"half_mark_answers": half_mark_answers, "half_mark_answers": half_mark_answers,
"incorrect_answers": incorrect_answers, "incorrect_answers": incorrect_answers,