update dicom viewer to support load by imageid

atlas/views.py

@@ -1,6 +1,9 @@
 import json
 import pprint
+from typing import Any
 from dal import autocomplete
+from django.db.models.base import Model as Model
+from django.db.models.query import QuerySet
 from django.shortcuts import render, get_object_or_404, redirect
 from django import forms
 from django.utils import timezone
@@ -563,12 +566,21 @@ class CaseDelete(RevisionMixin, AuthorOrCheckerRequiredMixin, DeleteView):
     template_name = "confirm_delete.html"
 
 
+# TODO fix permissions
 class SeriesFindingDelete(RevisionMixin, PermissionRequiredMixin, DeleteView):
     permission_required = "atlas.delete_seriesfinding"
     model = SeriesFinding
     template_name = "confirm_delete.html"
     # success_url = reverse_lazy("atlas:case_view")
 
+    def get_object(self):
+        series_finding = super().get_object()
+        series = series_finding.series
+        if series.check_user_can_edit(self.request.user):
+            return series_finding
+        else:
+            raise PermissionDenied
+
     def get_success_url(self):
         pk = self.kwargs["pk"]
         series_id = get_object_or_404(SeriesFinding, pk=pk).series.id
@@ -1375,6 +1387,7 @@ class SeriesImagesZipView(SeriesImagesZipViewBase, SuperuserRequiredMixin):
     series_object = Series
 
 
+# At the moment only the series owner / author can delete findings but anyone can create
 def create_series_findings(request):
     # posts = Post.objects.all()
     response_data = {}