keep tring

atlas/tests/test_multiuser.py

@@ -1,5 +1,6 @@
 import pytest
 from django.urls import reverse
+from django.contrib.auth import get_user_model
 from atlas.models import Case, MultiuserSession
 from pytest_django.asserts import assertContains, assertRedirects
 
@@ -21,11 +22,14 @@ def test_multiuser_dashboard_view_anonymous_redirect(client):
     assertRedirects(response, f"{reverse('login')}?next={reverse('atlas:multiuser_dashboard')}")
 
 @pytest.mark.django_db
-def test_multiuser_dashboard_lists_sessions(client, create_user):
+def test_multiuser_dashboard_lists_sessions_staff(client, create_user):
     user = create_user
+    user.is_staff = True
+    user.save()
     session1 = MultiuserSession.objects.create(name="User Session 1", creator=user)
     
-    other_user = create_user
+    User = get_user_model()
+    other_user = User.objects.create_user(username="other", password="password", email="other@test.com")
     session2 = MultiuserSession.objects.create(name="Other Session 2", creator=other_user)
     
     client.force_login(user)
@@ -35,18 +39,46 @@ def test_multiuser_dashboard_lists_sessions(client, create_user):
     assertContains(response, "Other Session 2")
     assertContains(response, "Start New Session")
 
+@pytest.mark.django_db
+def test_multiuser_dashboard_lists_sessions_non_staff(client, create_user):
+    user = create_user
+    
+    User = get_user_model()
+    other_user = User.objects.create_user(username="other", password="password", email="other@test.com")
+    other_user.is_staff = True
+    other_user.save()
+    session2 = MultiuserSession.objects.create(name="Other Session 2", creator=other_user)
+    
+    client.force_login(user)
+    response = client.get(reverse("atlas:multiuser_dashboard"))
+    assert response.status_code == 200
+    assertContains(response, "Other Session 2")
+    assert "Start New Session" not in response.content.decode("utf-8")
+    assert "Sessions You Managed" not in response.content.decode("utf-8")
+
 @pytest.mark.django_db
 def test_multiuser_create_session_action(client, create_user):
-    client.force_login(create_user)
+    user = create_user
+    user.is_staff = True
+    user.save()
+    client.force_login(user)
     response = client.post(reverse("atlas:multiuser_create_session"), data={"name": "My New Session"})
     
     session = MultiuserSession.objects.get(name="My New Session")
     assertRedirects(response, reverse("atlas:multiuser_session_detail", kwargs={"session_id": session.id}))
 
 @pytest.mark.django_db
-def test_multiuser_session_detail_manager_vs_participant(client, create_user):
-    manager = create_user
-    participant = create_user
+def test_multiuser_create_session_action_non_staff_denied(client, create_user):
+    user = create_user
+    client.force_login(user)
+    response = client.post(reverse("atlas:multiuser_create_session"), data={"name": "Denied Session"})
+    assert response.status_code == 302 # Redirected to admin login page because of @staff_member_required
+
+@pytest.mark.django_db
+def test_multiuser_session_detail_manager_vs_participant(client):
+    User = get_user_model()
+    manager = User.objects.create_user(username="manager", password="password", email="manager@test.com")
+    participant = User.objects.create_user(username="participant", password="password", email="participant@test.com")
     session = MultiuserSession.objects.create(name="Collaboration Session", creator=manager)
     
     # Manager view
@@ -64,9 +96,10 @@ def test_multiuser_session_detail_manager_vs_participant(client, create_user):
     assertContains(response, "You are viewing this session in real-time")
 
 @pytest.mark.django_db
-def test_multiuser_search_cases_permission(client, create_user):
-    manager = create_user
-    participant = create_user
+def test_multiuser_search_cases_permission(client):
+    User = get_user_model()
+    manager = User.objects.create_user(username="manager", password="password", email="manager@test.com")
+    participant = User.objects.create_user(username="participant", password="password", email="participant@test.com")
     session = MultiuserSession.objects.create(name="Search Session", creator=manager)
     
     # Participant cannot search
@@ -80,9 +113,10 @@ def test_multiuser_search_cases_permission(client, create_user):
     assert response.status_code == 200
 
 @pytest.mark.django_db
-def test_multiuser_load_case_action(client, create_user, make_case):
-    manager = create_user
-    participant = create_user
+def test_multiuser_load_case_action(client, make_case):
+    User = get_user_model()
+    manager = User.objects.create_user(username="manager", password="password", email="manager@test.com")
+    participant = User.objects.create_user(username="participant", password="password", email="participant@test.com")
     session = MultiuserSession.objects.create(name="Load Case Session", creator=manager)
     
     case = make_case(title="Multiuser Dicom Case")