Refactor case_order_dicom function to add type hint for case and improve error handling messages
This commit is contained in:
+3
-3
@@ -1655,7 +1655,7 @@ class FindingView(LoginRequiredMixin, UserConfigurablePaginationMixin, SingleTab
|
||||
@login_required
|
||||
def case_order_dicom(request, pk):
|
||||
if request.htmx:
|
||||
case = get_object_or_404(Case, pk=pk)
|
||||
case: Case = get_object_or_404(Case, pk=pk)
|
||||
|
||||
fail = []
|
||||
# TODO: don't try to order non stack series
|
||||
@@ -1664,9 +1664,9 @@ def case_order_dicom(request, pk):
|
||||
if request.user in series.get_author_objects():
|
||||
series.order_by_dicom()
|
||||
else:
|
||||
fail.append(series.pk)
|
||||
fail.append(f"{series.pk}: invalid permission")
|
||||
except:
|
||||
fail.append(series.pk)
|
||||
fail.append(f"{series.pk}: error")
|
||||
|
||||
if fail:
|
||||
return HttpResponse(
|
||||
|
||||
Reference in New Issue
Block a user