ross/penracourses
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor case_order_dicom function to add type hint for case and improve error handling messages

Browse Source
This commit is contained in:
Ross
2025-08-18 09:43:58 +01:00
parent 2a351a8283
commit 4afcfb6b26
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
atlas/views.py
+3 -3
View File
@@ -1655,7 +1655,7 @@ class FindingView(LoginRequiredMixin, UserConfigurablePaginationMixin, SingleTab
@login_required @login_required
def case_order_dicom(request, pk): def case_order_dicom(request, pk):
if request.htmx: if request.htmx:
case = get_object_or_404(Case, pk=pk) case: Case = get_object_or_404(Case, pk=pk)
fail = [] fail = []
# TODO: don't try to order non stack series # TODO: don't try to order non stack series
@@ -1664,9 +1664,9 @@ def case_order_dicom(request, pk):
if request.user in series.get_author_objects(): if request.user in series.get_author_objects():
series.order_by_dicom() series.order_by_dicom()
else: else:
fail.append(series.pk) fail.append(f"{series.pk}: invalid permission")
except: except:
fail.append(series.pk) fail.append(f"{series.pk}: error")
if fail: if fail:
return HttpResponse( return HttpResponse(